World and Apriltags #108
Open
World and Apriltags #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendes
force-pushed
the
camera_world
branch
from
926ab8d
to
2a0ef1d
Compare
|
UPDATE 1 Added launch file. Added apriltag on Create Robot. Erased two unnecessary cameras. Still need to address: Optical Frame for the camera READY FOR REVIEW |
Did you add this feature? If not, please, do it. |
eborghi10
requested changes
Oct 20, 2019
|
UPDATE 2
|
| </noise> | ||
| </camera> | ||
| <plugin name="camera_controller" filename="libgazebo_ros_camera.so"> | ||
| <alwaysOn>true</alwaysOn> |
There was a problem hiding this comment.
Is alwaysOn a valid plugin tag?
There was a problem hiding this comment.
Check updateRate too
There was a problem hiding this comment.
To what I saw, always_on is a tag for the sensor and alwaysOn is used in plugins, same case with updateRate
eborghi10
requested changes
Oct 22, 2019
Added world and models Big changes,added launch file, apriltag on create robot, erased to cameras, cleaned the world file Changed the apriltags and camera plugin fixup! Adding new world Change apriltags for improve the visualization Added in launch file apriltag and tf_state nodes
stevendes
force-pushed
the
camera_world
branch
from
5a003df
to
9c0df02
Compare
eborghi10
force-pushed
the
kinetic-devel
branch
3 times, most recently
from
23e75d6
to
05fa7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
World and Apriltags
Created the world with 3 cameras and 2 apriltags.
Still missing launchfile and apriltag on the create robot model.
World file with some commented code that needs to be erased.
Cameras still missing the model file, for now they are created right in the .world file.
UPDATE
Addressed all the comments
Include in the launch file the apriltag node run and the tf_state_publisher