fix for an issue described #164, NIO TCP connection bug #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pimenas Thanks for the PR ❤️ - appreciate you taking the time to contribute this!! Could you please make sure you've signed our CLA as well? Thanks in advance! |
pimenas
changed the title
|
@gsaslis I remember signing the CLA a few months ago, when I made some other minor contributions. |
|
sorry for the confusion @pimenas ! Passing this on for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue described in the second comment in #164, and allows outgoing TCP connections once again (they were broken in commit 365fb3e)