TASK-4197 fixed all PMD violations caused by PMD update

.github/workflows/build.yml

@@ -21,7 +21,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 17
+          java-version: 21
           cache: 'maven'
       - name: Build with Maven verify
         run: ./mvnw -B verify

pom.xml

@@ -5,7 +5,7 @@
 	<parent>
 		<groupId>works.reload</groupId>
 		<artifactId>parent</artifactId>
-		<version>1.0.5</version>
+		<version>1.2.0</version>
 	</parent>
 
 	<groupId>org.wensheng</groupId>

src/main/java/org/wensheng/juicyraspberrypie/RemoteSession.java

@@ -52,6 +52,7 @@
 import java.net.Socket;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayDeque;
+import java.util.Deque;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -76,9 +77,9 @@ class RemoteSession {
 	@SuppressWarnings("PMD.DoNotUseThreads")
 	private Thread outThread;
 
-	private final ArrayDeque<String> inQueue = new ArrayDeque<>();
+	private final Deque<String> inQueue = new ArrayDeque<>();
 
-	private final ArrayDeque<String> outQueue = new ArrayDeque<>();
+	private final Deque<String> outQueue = new ArrayDeque<>();
 
 	private boolean running = true;
 
@@ -256,6 +257,7 @@ private class OutputThread implements Runnable {
 		public OutputThread() {
 		}
 
+		@SuppressWarnings("PMD.DoNotUseThreads")
 		@Override
 		public void run() {
 			logger.log(Level.INFO, "Starting output thread!");

src/main/java/org/wensheng/juicyraspberrypie/command/handlers/events/EventQueue.java

@@ -6,6 +6,7 @@
 import org.wensheng.juicyraspberrypie.command.Handler;
 
 import java.util.ArrayDeque;
+import java.util.Deque;
 
 /**
  * An event queue for handling events.
@@ -16,7 +17,7 @@ public abstract class EventQueue<T extends Event> implements Handler, Listener {
 	/**
 	 * The event queue.
 	 */
-	private final ArrayDeque<T> events = new ArrayDeque<>();
+	private final Deque<T> events = new ArrayDeque<>();
 
 	/**
 	 * The plugin to associate with this event queue.

src/main/java/org/wensheng/juicyraspberrypie/command/handlers/events/block/Hits.java

@@ -47,11 +47,7 @@ public String handle(final Instruction instruction) {
 			final Block block = event.getClickedBlock();
 			if (block != null) {
 				final Location loc = block.getLocation();
-				stringBuilder.append(getBlockLocation(loc));
-				stringBuilder.append(',');
-				stringBuilder.append(event.getBlockFace().name());
-				stringBuilder.append(',');
-				stringBuilder.append(event.getPlayer().getUniqueId());
+				stringBuilder.append(getBlockLocation(loc)).append(',').append(event.getBlockFace().name()).append(',').append(event.getPlayer().getUniqueId());
 			} else {
 				stringBuilder.append("0,0,0,Fail,0");
 			}

src/main/java/org/wensheng/juicyraspberrypie/command/handlers/events/chat/Posts.java

@@ -27,11 +27,7 @@ public String handle(final Instruction instruction) {
 		while (isQueueEmpty()) {
 			final AsyncPlayerChatEvent event = pollEvent();
 			final Player player = event.getPlayer();
-			stringBuilder.append(player.getName());
-			stringBuilder.append(',');
-			stringBuilder.append(player.getUniqueId());
-			stringBuilder.append(',');
-			stringBuilder.append(event.getMessage());
+			stringBuilder.append(player.getName()).append(',').append(player.getUniqueId()).append(',').append(event.getMessage());
 			if (!isQueueEmpty()) {
 				stringBuilder.append('|');
 			}

src/main/java/org/wensheng/juicyraspberrypie/command/handlers/events/projectile/Hits.java

@@ -36,10 +36,7 @@ public String handle(final Instruction instruction) {
 			if (player != null) {
 				final Block block = arrow.getLocation().getBlock();
 				final Location loc = block.getLocation();
-				stringBuilder.append(getBlockLocation(loc));
-				stringBuilder.append(',');
-				stringBuilder.append(player.getUniqueId());
-				stringBuilder.append(',');
+				stringBuilder.append(getBlockLocation(loc)).append(',').append(player.getUniqueId()).append(',');
 				final Entity hitEntity = event.getHitEntity();
 				if (hitEntity != null) {
 					stringBuilder.append(hitEntity.getUniqueId());

src/main/java/org/wensheng/juicyraspberrypie/command/handlers/world/GetPlayerIds.java

@@ -27,10 +27,7 @@ public GetPlayerIds(final Server server) {
 	public String handle(final Instruction instruction) {
 		final StringBuilder bdr = new StringBuilder();
 		for (final Player p : server.getOnlinePlayers()) {
-			bdr.append(p.getName());
-			bdr.append(',');
-			bdr.append(p.getUniqueId());
-			bdr.append('|');
+			bdr.append(p.getName()).append(',').append(p.getUniqueId()).append('|');
 		}
 		if (!bdr.isEmpty()) {
 			bdr.deleteCharAt(bdr.length() - 1);