Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{D,Z}BBCSD: stricter zero criterion #966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christoph-conrads
Copy link
Contributor

Description

The tolerance below which matrix entries are considered zero is tightened to avoid insufficiently accurate singular vectors.

I cannot locate more information about the zero criterion and the choice may be too conservative: there is no information in the git history about it (only the final code was committed in 2010) and in the article Computing the Complete CS Decomposition (2008) from the code author, it only says:

To encourage fast termination, some angles in θ(n) and φ(n) may need to be rounded when they are negligibly far from 0 or π/2. The best test for negligibility will be the subject of future work.

The article Stable Computation of the CS Decomposition: Simultaneous Bidiagonalization does not discuss the zero criterion.

Checklist

  • The documentation has been updated.
  • If the PR solves a specific issue, it is set to be closed on merge.

The tolerance below which matrix entries are considered zero is
tightened to avoid insufficiently accurate singular vectors.

fixes Reference-LAPACK#965
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (db501d9) 0.00% compared to head (1d6b882) 0.00%.

Files Patch % Lines
SRC/dbbcsd.f 0.00% 1 Missing ⚠️
SRC/zbbcsd.f 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1930     1930           
  Lines      190421   190421           
=======================================
  Misses     190421   190421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant