Replace angular translation before its used #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Sep 24, 2024
| } | ||
| } | ||
| document.addEventListener("loadAngularJSi18n", function () { | ||
| if (typeof angular !== "undefined") { |
There was a problem hiding this comment.
is there any chance for angular to be undefined at this point?
There was a problem hiding this comment.
Probably not, but I thought to leave it as is? I can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs Katello/katello#11158
Explanation copy from that pr:
The deface for branding needs to happen (from
engines/bastion/app/views/bastion/layouts/assets.html.erb):<%= javascript_include_tag('bastion/bastion', {type: 'module'})%>translate(..., I think its in:<%= javascript_include_tag('bastion_katello/bastion_katello', {type: 'module'}) %>