Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

feat(route getting started page): getting started page #43

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
c95a00d
added stubs for all operators
btroncone Oct 3, 2017
11fc524
updated operator formatting
btroncone Oct 4, 2017
363484d
update lint settings
btroncone Oct 4, 2017
242b28d
correctly type doc objects
btroncone Oct 4, 2017
05fc934
styling and grouping updates
btroncone Oct 4, 2017
62cb886
basic operator outline
btroncone Oct 4, 2017
38f2c27
operator styling updates
btroncone Oct 4, 2017
ba8fbbf
sidenav navigation tweaks
btroncone Oct 4, 2017
e886d00
operator toc start
btroncone Oct 4, 2017
0cbec6f
operator styling progress
btroncone Oct 5, 2017
0f25ced
styling updates
btroncone Oct 6, 2017
90577f1
updated to material beta.12
btroncone Oct 6, 2017
a6985eb
operator navigation update
btroncone Oct 8, 2017
bfb948e
added highlight.js
btroncone Oct 8, 2017
acea05d
operator routing update
btroncone Oct 8, 2017
a43f86d
operator formatting update
btroncone Oct 9, 2017
5bc28e2
styling and formatting updates
btroncone Oct 9, 2017
bf4bd05
media helpers
btroncone Oct 9, 2017
94d4188
filling in info and styling updates
btroncone Oct 10, 2017
700b247
fixed source url
btroncone Oct 10, 2017
363f68f
merge upstream
btroncone Oct 10, 2017
f365292
update routing to module
btroncone Oct 10, 2017
317449b
split up operator components
btroncone Oct 10, 2017
2eaa156
added walkthrough
btroncone Oct 10, 2017
6c7f2c4
update active color
btroncone Oct 10, 2017
68a52b1
added copy + operator styling updates
btroncone Oct 11, 2017
a73d3b6
operator display tweaks
btroncone Oct 11, 2017
cdd9152
styling + quick link updates
btroncone Oct 12, 2017
df94a2c
Merge branch 'master' into operator-section
btroncone Oct 12, 2017
0bf3e2b
removed unused routes
btroncone Oct 13, 2017
0e681a0
added jsbin iframe for examples
btroncone Oct 16, 2017
a8311b7
rx-marbles integration + responsive updates
btroncone Oct 17, 2017
2b9614f
merge master
btroncone Oct 17, 2017
a912ee9
header styling update
btroncone Oct 17, 2017
a9ae9c8
added initial tests for operators component
btroncone Oct 18, 2017
4ea7a07
feat(route getting started page): getting started page
Oct 18, 2017
fd8a605
fix(removing test): removing test
Oct 18, 2017
988b277
testing out the addition of commitizen
Oct 18, 2017
2c533f9
feat($compile): add commitizen wizard for easy commit message creation
Oct 18, 2017
eef6095
docs(README.md): add references to external content
Oct 18, 2017
1b93013
docs(Remove extra nonexistent links): Remove links to docs that do no…
Oct 18, 2017
6b8a324
docs(Readme.md): Add license line
Oct 18, 2017
c63d3db
docs(Readme.md): Update badge urls
Oct 18, 2017
abd2cf4
feat(package.json, readme.md): add engines object to package.json
Oct 18, 2017
3faf503
docs(Remove all the docs and converage references): Removed reference…
Oct 18, 2017
84e507c
docs(CONTRIBUTING.md and README.md): Improve Readme and Contributing …
Oct 18, 2017
7cb3669
docs(CONTRIBUTING.md): Changed reference to rxjs docs
Oct 18, 2017
aec9e36
Merge pull request #44 from knittingcodemonkey/addToReadme
ladyleet Oct 18, 2017
8a18c13
docs(CONTRIBUTING.md, README.md): Add instructions regarding commit s…
Oct 18, 2017
b6344d9
Merge pull request #46 from knittingcodemonkey/commitScriptDocumentation
kwonoj Oct 18, 2017
c1bfa0b
fix(link to external docs): Review comments
Oct 19, 2017
5ba0dc8
feat(route getting started page): getting started page
Oct 18, 2017
ca398e1
fix(removing test): removing test
Oct 18, 2017
209b790
fix(link to external docs): Review comments
Oct 19, 2017
56a6d11
Merge branch 'arat3091/pr33-getting-started-guide' of https://github.…
Oct 19, 2017
d22320a
Merge remote-tracking branch 'upstream/master' into operator-section
btroncone Oct 20, 2017
f454d49
style(operators): split description between lines to fix linting problem
btroncone Oct 20, 2017
73a724e
Merge pull request #34 from btroncone/operator-section
ladyleet Oct 21, 2017
99b382b
chore(tooling): Add prettier, lint-staged and precommit hook for tooling
ashwin-sureshkumar Oct 19, 2017
b78856e
Merge pull request #49 from ashwin-sureshkumar/issue-45
ladyleet Oct 21, 2017
35fdf0b
chore(danger): fix dangerfile
kwonoj Oct 21, 2017
c45f65c
Merge pull request #59 from kwonoj/fix-lodash
kwonoj Oct 21, 2017
4c6ce9e
chore(danger): update rules
kwonoj Oct 23, 2017
626fa7d
chore(travis): update build coverage config
kwonoj Oct 23, 2017
86bdde6
Merge pull request #60 from kwonoj/chore-coverage
kwonoj Oct 23, 2017
82b830a
feat(route getting started page): getting started page
Oct 18, 2017
fba476d
fix(removing test): removing test
Oct 18, 2017
2726b16
fix(link to external docs): Review comments
Oct 19, 2017
e3992c9
fix(merge from upstream)
Oct 23, 2017
a025699
fix(removing test): removing test
Oct 18, 2017
d9bcd7e
Merge branch 'arat3091/pr33-getting-started-guide' of https://github.…
Oct 23, 2017
47bf72c
fix(adding formatting)
Oct 23, 2017
d0e1c08
fix(getting started guide): getting started guide
Oct 23, 2017
5e153c8
fix(guide): guide for starters
Oct 23, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ before_install:
script:
- if [ -n "DANGER_GITHUB_API_TOKEN" ]; then echo {} > ./.babelrc && npx danger; fi
- ng lint
- ng test --single-run
- ng build -prod
- ng test --single-run --code-coverage
- ng build --prod
- ng e2e

before_deploy:
Expand All @@ -37,4 +37,7 @@ before_deploy:
deploy:
provider: azure_web_apps
verbose: true
skip_cleanup: true
skip_cleanup: true

after_success:
- bash <(curl -s https://codecov.io/bash)
173 changes: 173 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,173 @@
# Contributing to RxJS Docs

[Read and abide by the Code of Conduct](CODE_OF_CONDUCT.md)! Even if you don't read it,
it still applies to you. Ignorance is not an exemption.

Contents

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

- [Submitting a Pull Request (PR)](#submitting-a-pull-request-pr)
- [After your pull request is merged](#after-your-pull-request-is-merged)
- [Commit Message Guidelines](#commit-message-guidelines)
- [Commit Message Format](#commit-message-format)
- [Revert](#revert)
- [Type](#type)
- [Scope](#scope)
- [Subject](#subject)
- [Body](#body)
- [Footer](#footer)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

(This document is a work and progress and is subject to change)

## Building/Testing

The build and test structure is fairly primitive at the moment. There are various npm scripts that can be run:

- start: runs the dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.
- test: runs tests with `jasmine`, must have built prior to running.
- build: build artifacts will be stored in the `dist/` directory
- build-prod: builds for production using the `--prod` flag
- commit: runs git commit wizard for passing rxjs-github-bot message validator

## Submitting a Pull Request (PR)
Before you submit your Pull Request (PR) consider the following guidelines:

* Search [GitHub](https://github.com/ReactiveX/rxjs-docs/pulls) for an open or closed PR
that relates to your submission. You don't want to duplicate effort.
* Make your changes in a new git branch:

```shell
git checkout -b my-fix-branch master
```

* Create your patch, following [code style guidelines](#coding-style-guidelines), and **including appropriate test cases**.
* Run the full test suite and ensure that all tests pass.
* Run the micro and macro performance tests against your feature branch and compare against master
to ensure performance wasn't changed for the worse.
* Commit your changes using a descriptive commit message that follows our
[commit message guidelines](#commit-message-guidelines). Adherence to these conventions
is necessary because release notes are automatically generated from these messages.

```shell
git add .
npm run commit
```
Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.

* Push your branch to GitHub:

```shell
git push origin my-fix-branch
```

* In GitHub, send a pull request to `rxjs-docs:master`.
* If we suggest changes then:
* Make the required updates.
* Re-run the test suites to ensure tests are still passing.
* Re-run performance tests to make sure your changes didn't hurt performance.
* Rebase your branch and force push to your GitHub repository (this will update your Pull Request):

```shell
git rebase master -i
git push -f
```

That's it! Thank you for your contribution!


### After your pull request is merged

After your pull request is merged, you can safely delete your branch and pull the changes
from the main (upstream) repository:

* Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:

```shell
git push origin --delete my-fix-branch
```

* Check out the master branch:

```shell
git checkout master -f
```

* Delete the local branch:

```shell
git branch -D my-fix-branch
```

* Update your master with the latest upstream version:

```shell
git pull --ff upstream master
```


- [Submitting a Pull Request (PR)](#submitting-a-pull-request-pr)
## Commit Message Guidelines

We have very precise rules over how our git commit messages can be formatted. This leads to **more
readable messages** that are easy to follow when looking through the **project history**. But also,
we use the git commit messages to **generate the rxjs-docs change log**. Helper script `npm run commit`
provides command line based wizard to format commit message easily.

### Commit Message Format
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
format that includes a **type**, a **scope** and a **subject**:

```
<type>(<scope>): <subject>
<BLANK LINE>
<body>
<BLANK LINE>
<footer>
```

The **header** is mandatory and the **scope** of the header is optional.

Any line of the commit message cannot be longer than 100 characters! This allows the message to be easier
to read on GitHub as well as in various git tools.

### Revert
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.

### Type
Must be one of the following:

* **feat**: A new feature
* **fix**: A bug fix
* **docs**: Documentation only changes
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing
semi-colons, etc)
* **refactor**: A code change that neither fixes a bug nor adds a feature
* **perf**: A code change that improves performance
* **test**: Adding missing tests
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation
generation

### Scope
The scope could be anything specifying place of the commit change. For example
`Observable`, `Subject`, `switchMap`, etc.

### Subject
The subject contains succinct description of the change:

* use the imperative, present tense: "change" not "changed" nor "changes"
* don't capitalize first letter
* no dot (.) at the end

### Body
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
The body should include the motivation for the change and contrast this with previous behavior.

### Footer
The footer should contain any information about **Breaking Changes** and is also the place to
reference GitHub issues that this commit **Closes**.

**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.
40 changes: 34 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,42 @@
[![Build Status](https://travis-ci.org/ReactiveX/rxjs-docs.svg?branch=master)](https://travis-ci.org/ReactiveX/rxjs-docs)

# rxjs-docs
The home for new work on the new RxJS docs (RxJS v5 and up)

## Development server
License is the same as the RxJS project: https://github.com/reactivex/rxjs

Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.
[Apache 2.0 License](LICENSE.txt)
- [Code of Conduct](CODE_OF_CONDUCT.md)
- [Contribution Guidelines](CONTRIBUTING.md)

## Build
## Important

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory. Use the `-prod` flag for a production build.
By contributing or commenting on issues in this repository, whether you've read them or not, you're agreeing to the [Contributor Code of Conduct](CODE_OF_CONDUCT.md). Much like traffic laws, ignorance doesn't grant you immunity.

## License
## Goals

License is the same as the RxJS project: https://github.com/reactivex/rxjs
- Serve updated docs for RxJs
- Serve multiple translations for the docs
- Provide working examples

## Contributing

More detailed information can be found in the [Contribution Guidelines](CONTRIBUTING.md)

## Building/Testing

The build and test structure is fairly primitive at the moment. There are various npm scripts that can be run:

- start: runs the dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.
- test: runs tests with `jasmine`, must have built prior to running.
- build: build artifacts will be stored in the `dist/` directory
- build-prod: builds for production using the `--prod` flag
- commit: runs git commit wizard for passing rxjs-github-bot message validator

## Committing
It is strongly recommended that when creating a commit, you follow this procedure to start the commit wizard. It will aid you on creating valid commit messages.

```shell
git add .
npm run commit
```
3 changes: 2 additions & 1 deletion dangerfile.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const fs = require('fs');
const path = require('path');
const validateMessage = require('validate-commit-msg');
const _ = require('lodash');

let errorCount = 0;

Expand Down Expand Up @@ -38,6 +39,6 @@ const messageConventionValid = danger.git.commits.reduce(function (acc, value) {
}, true);

if (!messageConventionValid) {
warn('commit message does not follows conventional change log (' + ++errorCount + ')');
fail('commit message does not follows conventional change log (' + ++errorCount + ')');
markdown('> (' + errorCount + ') : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check [contributing guideline](https://github.com/ReactiveX/rxjs/blob/master/CONTRIBUTING.md#commit-message-format) and update commit messages.');
}
9 changes: 7 additions & 2 deletions ngsw-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,14 @@
"external": {
"urls": [
{"url": "https://fonts.googleapis.com/icon?family=Material+Icons"},
{"url": "https://fonts.googleapis.com/css?family=Roboto"},
{"url": "https://fonts.googleapis.com/css?family=Roboto:300,400,500,600,700"},
{"url": "https://ajax.googleapis.com/ajax/libs/hammerjs/2.0.8/hammer.min.js"},
{"url": "https://cdnjs.cloudflare.com/ajax/libs/web-animations/2.2.5/web-animations.min.js"}
{"url": "https://cdnjs.cloudflare.com/ajax/libs/web-animations/2.2.5/web-animations.min.js"},
{"url": "https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.5.0/styles/monokai_sublime.min.css"},
{"url": "https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.5.0/highlight.min.js"},
{"url": "https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.5.0/languages/typescript.min.js"},
{"url": "http://reactivex.io/rxjs/img/combineAll.png"},
{"url": "http://reactivex.io/rxjs/img/combineLatest.png"}
]
}
}
Loading