Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighted button draw oversized width and height #1434

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Fix highlighted button draw oversized width and height #1434

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7969dff
-- Imgui Shims
GoranKovac Apr 17, 2024
0ddcd52
Merge branch 'ReaTeam:master' into master
GoranKovac Jul 29, 2024
3e52470
-- version 1.21
GoranKovac Jul 29, 2024
1dc3a0e
s/1.21/1.2.1/
cfillion Jul 29, 2024
a648dd5
Merge branch 'ReaTeam:master' into master
GoranKovac Sep 26, 2024
a3b9b32
-- version 1.01
GoranKovac Sep 26, 2024
caab87d
Merge branch 'ReaTeam:master' into master
GoranKovac Sep 27, 2024
3b298fe
-- version 1.02
GoranKovac Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Tracks/reapertips_Track icon selector.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
-- @description Track icon selector
-- @author Reapertips & Sexan
-- @version 1.01
-- @version 1.02
-- @changelog
-- Removed IsRectVisible optiomization (not doing much but introduceds other problems)
-- Fix highlighted button draw oversized width and height
-- @screenshot
-- https://i.imgur.com/bFK2HYk.png
-- https://i.imgur.com/MabMOW1.png
Expand Down Expand Up @@ -282,15 +282,12 @@ local function PngSelector(button_size)
for n = 0, #FILTERED_PNG - 1 do
local image = FILTERED_PNG[n + 1].name
local stripped_name = FILTERED_PNG[n + 1].short_name
local xx, yy = imgui.GetCursorPos(ctx)

imgui.PushID(ctx, n)
if not imgui.ValidatePtr(FILTERED_PNG[n + 1].img_obj, 'ImGui_Image*') then
FILTERED_PNG[n + 1].img_obj = imgui.CreateImage(image)
end

imgui.SetCursorPos(ctx, xx, yy)

if imgui.ImageButton(ctx, "##png_select", FILTERED_PNG[n + 1].img_obj, button_size, button_size, 0, 0, 1, 1) then
for i = 1, #TRACKS do
r.GetSetMediaTrackInfo_String(TRACKS[i], "P_ICON", image, true)
Expand All @@ -313,7 +310,7 @@ local function PngSelector(button_size)
SCROLL_TO_IMG = true
LAST_ICON = CUR_ICON
end
imgui.DrawList_AddRect(DRAW_LIST, minx, miny, maxx + (padding*2), maxy + padding*2, COLORS["outline_col"], 0, 0, 2)
imgui.DrawList_AddRect(DRAW_LIST, minx, miny, maxx, maxy, COLORS["outline_col"], 0, 0, 2)
if SCROLL_TO_IMG then
SCROLL_TO_IMG = nil
imgui.SetScrollHereY(ctx)
Expand Down