-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update GLCI (warnings + docs) #6586
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6586 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14516 14516
=======================================
Hits 14314 14314
Misses 202 202 ☔ View full report in Codecov by Sentry. |
Generated via commit 07029a6 Download link for the artifact containing the test results: ↓ atime-results.zip
|
@@ -21,7 +21,7 @@ | |||
// Where no halt is happening, we can just use raw Rprintf() or warning() | |||
void __halt(bool warn, const char *format, ...); // see freadR.c | |||
#define STOP(...) __halt(0, __VA_ARGS__) | |||
static char internal_error_buff[1001]; // match internalErrSize | |||
static char internal_error_buff[1001] __attribute__((unused)); // match internalErrSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fixable (#6468), let's mark with TODO for now if we want to ignore it in the interim.
Otherwise it's strange to the reader to see unused
and then it's used in the next line.
CI results