Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test 1623 if '~' not defined #6577

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mfansler
Copy link

Fixes #6576

This skips the test if "~" is undefined on the system. However, a better solution might be to test a directory that is guaranteed to exist, e.g., tempdir().

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (315ab54) to head (9d4ca4f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6577   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14450    14450           
=======================================
  Hits        14251    14251           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member

a better solution might be to test a directory that is guaranteed to exist, e.g., tempdir().

I'm fairly confident that's done elsewhere, the reason I suggested a skip here is the reference issue is specifically about an attempt to read ~:

#989

so a regression test against that path specifically makes sense to me still.

@mfansler
Copy link
Author

Sounds good!

@tdhock
Copy link
Member

tdhock commented Oct 17, 2024

thanks for your analysis and PR!
I invited you to https://github.com/orgs/Rdatatable/teams/project-members so after accepting, please send future PRs from Rdatatable/data.table instead of your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test 1623 failure in Conda Forge Windows builds
3 participants