-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian translation of the gettext messages files #6516
base: master
Are you sure you want to change the base?
Conversation
Hi this is Nichole Haines. I didn't get a grant pay out yet.
…On Sat, Sep 21, 2024, 8:15 AM aitap ***@***.***> wrote:
First of all, big thanks to @Meeko28 <https://github.com/Meeko28> and
@Kate-lz <https://github.com/Kate-lz>! This would have never been
possible without your work. I hope that you've received your grant payouts,
or at least that the paperwork is on the way.
The *.po files are prepared against the current *.pot files, so a few of
the strings containing fragmented sentences have been left untranslated.
Questions:
- Should this pull request be WIP until all the *.pot files are
updated? I've got to submit some edits for the R message templates too, and
the vignettes and the help pages may need their own rounds of editing too.
- Where do I put the data.table.ru package
<https://codeberg.org/aitap/data.table.ru/src/branch/translated-package>
with the three vignettes (intro, reshape, importing) and (currently) 25% of
the help pages translated? I ended up using a po4a <https://po4a.org/>-based
workflow for the vignettes (thank you very much @phgrosjean
<https://github.com/phgrosjean> for the hint) and a similar but more handmade
workflow <https://codeberg.org/aitap/Rd2gettext> for the help files.
The resulting package (when built) depends on only data.table and
suggests a few of its dependencies (to build vignettes and run examples).
------------------------------
You can view, comment on, or merge this pull request online at:
#6516
Commit Summary
- 2d8565c
<2d8565c>
Import Russian translations
- 999d316
<999d316>
Generate Russian *.mo files
File Changes
(4 files <https://github.com/Rdatatable/data.table/pull/6516/files>)
- *A* inst/po/ru/LC_MESSAGES/R-data.table.mo
<https://github.com/Rdatatable/data.table/pull/6516/files#diff-98af78fcf8f059ad7d54afdf3181545fb8bd4e50d1bf78bedd41fb7c19e871cd>
(0)
- *A* inst/po/ru/LC_MESSAGES/data.table.mo
<https://github.com/Rdatatable/data.table/pull/6516/files#diff-a7d2a75665321ab130c6911f06829df2471ec6d94b049ac77704c09db45750b8>
(0)
- *A* po/R-ru.po
<https://github.com/Rdatatable/data.table/pull/6516/files#diff-364263e332536dc6ed6cb516aad03be63ebac11544c3bc0f9d2c4172f8089dd7>
(3415)
- *A* po/ru.po
<https://github.com/Rdatatable/data.table/pull/6516/files#diff-92817e54c697fd6395db7e9eca8f2468538e83db228823136eaa96d834d74f76>
(4545)
Patch Links:
- https://github.com/Rdatatable/data.table/pull/6516.patch
- https://github.com/Rdatatable/data.table/pull/6516.diff
—
Reply to this email directly, view it on GitHub
<#6516>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKTIDASJDBTTB5VVTEDGIQTZXVPP5AVCNFSM6AAAAABOTRHZJKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DAMRSGA2DAMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yea, given our normal workflow is to update .pot near release time, I think it's not ideal to trigger the update now... if it's not too much trouble, we could "left join" the the current .pot to your translations as a PR to merge now, then leave this one pending until the .pot is updated (which will probably end up invalidating some translations here). |
Let's try this. I've ran |
Should I be preparing a new pull request? I think the current branch will |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6516 +/- ##
==========================================
+ Coverage 97.51% 98.62% +1.10%
==========================================
Files 80 79 -1
Lines 14979 14450 -529
==========================================
- Hits 14607 14251 -356
+ Misses 372 199 -173 ☔ View full report in Codecov by Sentry. |
Sorry @aitap, haven't had time to look closely. Will report back soon :) |
First of all, big thanks to @Meeko28 and @Kate-lz! This would have never been possible without your work. I hope that you've received your grant payouts, or at least that the paperwork is on the way.
The
*.po
files are prepared against the current*.pot
files, so a few of the strings containing fragmented sentences have been left untranslated.Questions:
*.pot
files are updated? I've got to submit some edits for the R message templates too, and the vignettes and the help pages may need their own rounds of editing too.data.table.ru
package with the three vignettes (intro, reshape, importing) and (currently) 25% of the help pages translated? I ended up using a po4a-based workflow for the vignettes (thank you very much @phgrosjean for the hint) and a similar but more handmade workflow for the help files. The resulting package (when built) depends on onlydata.table
and suggests a few of its dependencies (to build vignettes and run examples).