Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos binaries #6421

Merged
merged 15 commits into from
Oct 21, 2024
Merged

Macos binaries #6421

merged 15 commits into from
Oct 21, 2024

Conversation

ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Aug 28, 2024

Follows #6398 and adds binaries for macosx

@jangorecki Is there also a way to pre-test the publishing mechanism without master?

Building + testing on different R versions on arm64 worked fine on CI

@ben-schwen ben-schwen requested review from jangorecki and removed request for MichaelChirico August 28, 2024 16:00
.ci/ci.R Outdated Show resolved Hide resolved
Co-authored-by: Michael Chirico <[email protected]>
@jangorecki
Copy link
Member

jangorecki commented Aug 28, 2024

Nice to see your active contribution in this field. I felt I am the only one that can do glci.

Regarding testing.

What I used in this case was to add to integration stage extra branch name of THIS branch, next to the master. So then integration also kicks in for this branch.

Alternatively, if this branch is up to date with master you could probably try to add this branch name also to deploy stage, but then please don't leave it for a night or so, but confirm after the pipeline finishes, and shorty after finishing testing rerun pipeline for master. It is easy from web ui to run pipeline on demand, without need for any new commits.

Ultimately what you can do for testing is to self host gitlab, this is what I did in the distant past, using docker was pretty easy. Although not sure if public runners will work on self hosted instance.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (058dd4d) to head (b586b5a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6421   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          79       79           
  Lines       14516    14516           
=======================================
  Hits        14314    14314           
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ben-schwen
Copy link
Member Author

CI results look good.

Cran-like checks

@jangorecki
Copy link
Member

No binaries for Mac R-devel?

@ben-schwen
Copy link
Member Author

No binaries for Mac R-devel?

There is no .pkg for Mac for R-devel and I'm not familiar enough with osx for building it myself

@jangorecki
Copy link
Member

Fair enough. Therefore that most likely implies much less users of r-devel on Mac.

@MichaelChirico MichaelChirico merged commit 717981d into master Oct 21, 2024
10 checks passed
@MichaelChirico MichaelChirico deleted the macos_binaries branch October 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants