-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip_absent to setcolorder #6044
Open
sluga
wants to merge
17
commits into
Rdatatable:master
Choose a base branch
from
sluga:skip-absent-for-setcolorder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9580c70
Mention the 2023 data.table community survey
sluga 0abcb02
Add skip_absent to setcolorder
sluga fbfc5d0
Merge branch 'master' into skip-absent-for-setcolorder
sluga 9e67be4
Update NEWS
sluga 6623250
Merge branch 'Rdatatable:master' into master
sluga cd48c30
Merge branch 'master' into skip-absent-for-setcolorder
sluga 67979e3
Pass skip_absent to colnamesInt
sluga e136643
Revert
sluga 420712d
Fix
sluga 7672d47
Add test
sluga 54eaeba
Update NEWS
sluga f374677
Improve performance
sluga b8997bd
Update man/setcolorder.Rd
MichaelChirico b135a29
style changes
MichaelChirico ed9165d
Add tests
sluga 1287753
Clarify NEWS entry
sluga a08ee8e
Reword
sluga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for
setcolorder(DT, c('a', 'b', 'd'), skip_absent=TRUE)
.The NEWS item currently reads like 'c' will be dropped from the output, which would be bad -- I would expect the above to be equivalent to
setcolorder(DT, c("a", "b"))
.