Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes #843

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Suggested changes #843

wants to merge 18 commits into from

Conversation

rjd1922
Copy link

@rjd1922 rjd1922 commented Apr 7, 2023

Updated ThunderWaveDescription to reflect that it always paralyzes
Fixed NPC in Cherrygrove Pokémon Center referring to the Communication Center when she meant the Cable Club
Changed Stick and Up-Grade to their modern names Leek and Upgrade
Changed Mr. Fuji's sprite to his sprite from Gen 1 (shared with the Dragon Shrine elders) instead of the generic old man sprite
Changed Blastoise's category name in the Pokédex to Shell in nonfaithful builds, since Shellfish was a mistranslation

Made Mr. Fuji use his sprite from Gen 1 (shared with the Dragon Shrine elders) instead of the generic old man sprite.
Made Mr. Fuji use his sprite from Gen 1 (shared with the Dragon Shrine elders) instead of the generic old man sprite.
Updated ThunderWaveDescription to reflect that it always paralyzes.
Changed mentions of "Communication Center" to the proper term "Cable Club".
text "The Communication"
line "Center upstairs"
cont "was just built."
text "The Cable Club"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HGSS also calls it the Communication Center.

@@ -161,7 +161,7 @@ endc
li "Smoke Ball"
li "Berserk Gene"
li "Light Ball"
li "Stick"
li "Leek"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need rearranging alphabetically, and renaming the constants+labels.

Removed extra spot from back sprite.
Removed white on Slowpoke's belly (only Slowbro has a white belly).
@itsdarsh
Copy link
Collaborator

itsdarsh commented Apr 22, 2023

Renaming Up-Grade to Upgrade is a good idea (Stick -> Leek already happened in 9bit) and the sprite changes for Slowpoke and Xatu aren't bad. I don't think the other changes should be merged, though.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stripe should still be present, just diagonal, like RSE:
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mean the stripe, but the black spot below it. The Crystal front sprite is based on the Gold sprite and removes the spot from its front sprite but not the back.

@itsdarsh
Copy link
Collaborator

Remove "Fixed NPC in Cherrygrove Pokémon Center referring to the Communication Center when she meant the Cable Club" and "Changed Stick and Up-Grade to their modern names Leek and Upgrade" (this already has changed on 9bit) from your PR and I'll merge this.

Changed Blastoise's category from Shellfish Pokémon to Shell Pokémon. It's a mistranslation as Blastoise clearly isn't a shellfish.
data/pokemon/dex_entries/009.asm Outdated Show resolved Hide resolved
Species name stays the same if faithful.
I love you Wooper, buy you have to evolve arms before you can punch.
Removed Attract from Staryu's TM learnset since it's useless as Staryu is genderless.
Removed Attract from Starmie's TM learnset; it's useless since Starmie is genderless.
It makes no sense for Gastly to learn punching moves, since it doesn't have arms (Sucker Punch isn't actually a punching move despite the name).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants