BUG: Fixes on Boellaard Scatter Filter #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hreshold value (less than AirThreshold now) and revisited the averaging of the "averageBehindPatient" value.
SimonRit
requested changes
Apr 27, 2023
|
I think you can modify this PR with only the change on the threshold. The rest should stay I believe and it would be good to have a few documentation notes. If you'd like, I can prepare a new PR later on. |
Agreed on the documentation notes. I've made the proper corrections. Let me know if I should do anything else. I believe you should be able to squash commits when merging the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the condition on AirThreshold value (less than AirThreshold now) and revisited the averaging of the "averageBehindPatient" value. Discussion on #454.