Skip to content

Commit

Permalink
Disabled implictiGemm FP16 due to NaN issue (#2072)
Browse files Browse the repository at this point in the history
* diable_implicitemm_fp16(1): disable fp16 of implictigemm

* diable_implicitemm_fp16(2): add issue no
  • Loading branch information
zjing14 authored and Daniel Lowell committed Sep 11, 2019
1 parent a5ee8d5 commit 18c949e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/solver/conv_hip_implicit_gemm_v4_fwd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ namespace solver {

bool ConvHipImplicitGemmV4Fwd::IsApplicable(const ConvolutionContext& ctx) const
{
bool isTypeSupported = (ctx.IsFp32() || ctx.IsFp16());
// disable IsFp16 due to NaN (issue #2071);
///\todo: 1) Fixed NaN issue in Fp16, 2) enable Fp16 and 3) add Fp16 tests
bool isTypeSupported = ctx.IsFp32();

// For fp16, when c*x*y % 64 == 0, 4 channels are accumulated through dot4 (2 * dot2) operation
// when c*x*y % 32 == 0, channels are accumulated through dot2 operation.
Expand Down

0 comments on commit 18c949e

Please sign in to comment.