Bug fixes + adding possibility to switch from bytecode interpreter to DAST interpreter and vice-versa #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryVariable and ArgumentVariable
updating ASTInterpreter and ASTPostOrderTreeVisitor according to new AST visitor API
…cy to the baseline
removing deprecated spec-debugger dependency + adding espell dependen…
…uments for senders
…same result when resumed. It works but raises an exception "CannotReturn" afterwards and I don't know why
…ers, arguments and closure
…k context itself. Just like with DASTMethodContext, it works but it raises a Context>>#cannotReturn:
… DASTContext -> Context
Co-Authored-By: Steven Costiou <[email protected]>
… method is a DoIt
…ne mapped to current PC
- the stack remains the same - current node is last executed node - dast context chain is correct (the root is at the right place): this test is not green for now
- adding bc -> DAST interpreter switch test about being able to find bindings of variables inside closures that are defined in a context outside of these closures but that doesn't have an equivalent DAST context - skipping the test about receivers remaining the same before and after switch, because I'm not sure of what should be the receiver of a DASTBlockContext
…s (stack unchanged, receiver state unchanged, correct stepping, termination of process, running process with new context...) The test that checks bindings recursively and stack recursively are yellow for now
…kClosure in DASTBlock Vectors of temps need to be handled for DAST -> bc switch mapping indexes to right temps
Handling vectors of temps for DAST -> bc and bc -> DAST switches + tests
…n-DAST-and-bytecode-interpreters merging temp vectors handling to the experimental branch
…ion so that it becomes an exception that is only used to open a DASTDebugger
|
Looks like I forgot to commit an extension method there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #24
The "only" thing left to do is to be able to switch from optimized code in bytecode to non optimized code in DAST (and vice-versa)