-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
59 docker support #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to verify if we can push on GHCR for org, because I don't know :)
Another thing is to rewrite history of commits for consistency to the rest of the project
(very little thing, empty end line in yml are missing)
on: | ||
push: | ||
branches: | ||
- 'main' | ||
- 'develop' | ||
tags: | ||
- 'v*' | ||
paths: | ||
- "src/**" | ||
- "Cargo.toml" | ||
- "Cargo.lock" | ||
pull_request: | ||
branches: | ||
- 'main' | ||
paths: | ||
- "src/**" | ||
- "Cargo.toml" | ||
- "Cargo.lock" | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably is enough on a tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already tested the possibility to push into GHCR: it worked.
@@ -0,0 +1,9 @@ | |||
FROM rust:1.63 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest release is 1.64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it is possible also use :latest tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general is always better to choose a specific version instead of "latest" in order to have reproducible build. However this PR is on hold.
I found a criticity: Docker image is not working given insertion of UI. I guess we need:
|
Maybe the easiest is the first one, also because splitting UI it doesn't make really sense, since without UI is a useful gameboy 😓 |
I also think we shouldn't separate the UI. |
Closing for now because it's a weird way that we need to define before drafting some code |
Created a dockerfile for clementine and github action to push docker image on GHCR.
It is aimed to solve the issue #59