Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW] Fix Scoreboard Sorting #622

Merged
merged 2 commits into from Jul 9, 2023
Merged

[FW] Fix Scoreboard Sorting #622

merged 2 commits into from Jul 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2023

Add missing GameMode_SetScoreCompareFunc() for FW, so it's scoreboard will sort properly

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will need multiple people to test this in-game

@GeckoEidechse GeckoEidechse added the needs testing Changes from the PR still need to be tested label May 1, 2023
@F1F7Y F1F7Y added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels May 1, 2023
@GeckoEidechse
Copy link
Member

Someone test this please so that we can merge it <3

@ASpoonPlaysGames
Copy link
Contributor

Someone test this please so that we can merge it <3

I can assure you that, provided we use assault score for the main scoring in FW, this will work. It is very standard script code

@F1F7Y F1F7Y merged commit af8f5cd into R2Northstar:main Jul 9, 2023
3 checks passed
GeckoEidechse pushed a commit that referenced this pull request Jul 10, 2023
add missing GameMode_SetScoreCompareFunc() for fw

(cherry picked from commit af8f5cd)
@GeckoEidechse GeckoEidechse removed the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants