Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new features and missing language file #590

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

zxcPandora
Copy link
Contributor

@zxcPandora zxcPandora commented Feb 9, 2023

[Features]

  1. Add a check whether we should do respawn for late joiner(some gamemode should not let late joiner immediately spawn)
  2. Respawn Protection now will protect titan and add protection highlight both pilot/titan
  3. Add the missing language file(Avoid being covered by other languages):northstar_custom_tchinese.txt
  4. Add the missing localized string in english language file:fw_harvester_regen_time
  5. Avoid script error due to invalid rodeo target
    IUON%}XDRIGH}P9ZLYCRX
  6. Avoid server error:player while parented when playing cam
    HXJ4UJ5EJK)WT`X90WPLRWD
  7. Avoid server error:(I can delete this change if you want)
    _JJZ2A_3F E09MFOT L67
    Before:
    QQ截图20230223231420
    After:
    QQ截图20230223231447

@zxcPandora zxcPandora changed the title Main bug fix new features and missing language file Feb 9, 2023
@GeckoEidechse
Copy link
Member

Welp this kinda flew under my radar now. Got my hands full with 1.17 release atm, after that I think I should be able to give it another look. When I get to it, I'll try to grab some under contributor and split up the PR a bit and deal with resulting merge conflicts myself (ofc everything properly credited <3)

@GeckoEidechse
Copy link
Member

Just a heads-up that I did NOT forget about this PR, I'm just working through a massive backlog right now. I promise I will look at this PR as well <3

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Feb 28, 2024
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Mar 26, 2024
@GeckoEidechse
Copy link
Member

I think the best way of merging this PR is to take individual changes of it and making new smaller PRs with them. That way they are easier to review and test ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants