Include failure message in Nexus exception (temporalio#2251)

Quinn-With-Two-Ns · Oct 10, 2024 · 238ca06 · 238ca06
1 parent 1c509d6
commit 238ca06
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/temporal-sdk/src/main/java/io/temporal/failure/DefaultFailureConverter.java b/temporal-sdk/src/main/java/io/temporal/failure/DefaultFailureConverter.java
@@ -179,6 +179,7 @@ private TemporalFailure failureToExceptionImpl(Failure failure, DataConverter da
         {
           NexusOperationFailureInfo info = failure.getNexusOperationExecutionFailureInfo();
           return new NexusOperationFailure(
+              failure.getMessage(),
               info.getScheduledEventId(),
               info.getEndpoint(),
               info.getService(),

diff --git a/temporal-sdk/src/main/java/io/temporal/failure/NexusOperationFailure.java b/temporal-sdk/src/main/java/io/temporal/failure/NexusOperationFailure.java
@@ -38,13 +38,17 @@ public final class NexusOperationFailure extends TemporalFailure {
   private final String operationId;
 
   public NexusOperationFailure(
+      String message,
       long scheduledEventId,
       String endpoint,
       String service,
       String operation,
       String operationId,
       Throwable cause) {
-    super(getMessage(scheduledEventId, endpoint, service, operation, operationId), null, cause);
+    super(
+        getMessage(message, scheduledEventId, endpoint, service, operation, operationId),
+        message,
+        cause);
     this.scheduledEventId = scheduledEventId;
     this.endpoint = endpoint;
     this.service = service;
@@ -53,16 +57,24 @@ public NexusOperationFailure(
   }
 
   public static String getMessage(
+      String originalMessage,
       long scheduledEventId,
       String endpoint,
       String service,
       String operation,
       String operationId) {
     return "Nexus Operation with operation='"
         + operation
+        + "service='"
+        + service
+        + "' endpoint='"
+        + endpoint
+        + "' failed: '"
+        + originalMessage
         + "'. "
         + "scheduledEventId="
-        + scheduledEventId;
+        + scheduledEventId
+        + (operationId == null ? "" : ", operationId=" + operationId);
   }
 
   public long getScheduledEventId() {