-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering module #83
base: 1.18
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far
|
||
public static void register(ItemConvertible item, DynamicItemRenderer renderer) { | ||
Objects.requireNonNull(item, "item is null"); | ||
Objects.requireNonNull(item.asItem(), "item is null"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't ItemStack already disallows this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ItemStack
? ItemConvertable
is an interface and could return null.
...rc/main/java/org/quiltmc/qsl/rendering/registration/impl/client/BlockRenderLayerMapImpl.java
Show resolved
Hide resolved
- Remove DynamicItemRendererRegistry - Remove QuiltArmorMaterial in favor of getName returning a namespaced string - Revert license changes to block render layer map classes
Highlights:
BakedModelManager
for gettingBakedModel
s fromIdentifier
sEntityModelLayer
s toTexturedModelData
sArmorMaterial#getName
to return a namespaced texture locationTo do: