Port a few modules up to 1.21 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
added
library: entity
|
the deletions?? you're cooking?? |
Nope! Just using Mixin Extras |
This reverts commit d3d5e41.
Leaving disabled since I had to do some hacks to test.
Disabled a bunch of dependencies on res loader, make sure to fix this before merging
OroArmor
commented
Jul 21, 2024
| * @param overlay the overlay name | ||
| * @param pack the pack | ||
| */ | ||
| void putOverlay(@NotNull String overlay, ResourcePack pack); |
There was a problem hiding this comment.
@ix0rai @TheGlitch76 Im not too sure about this. Should it be a ResourcePack, where any pack can be part of the mutable pack, or does Consumer<ResourcePack> make more sense where the MutablePack implementation creates the pack in the way that it wants? Both options have their advantages.
There was a problem hiding this comment.
I have zero expertise in this area, it's really up to you...
|
@OroArmor can you compile a list of modules that you've ported in this PR? |
|
The list is:
Ported already (thanks glitch):
|
|
oh perf ok |
TheGlitch76
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the DISABLE files per module, making it less of a diff to enable them.