Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parquet-compression for lgbm #15
base: main
Are you sure you want to change the base?
parquet-compression for lgbm #15
Changes from all commits
f10b51e
bd952cd
0069ca0
8e6177e
cc0cffb
2fb8b84
3594a41
92178e1
439af86
78449aa
21071de
43b9f0c
91be951
5b44aba
e3b9217
37ed31f
cc8228b
660450b
7209db2
54e2889
fc09de9
0372263
5dbf70e
002de1d
62e20c7
b28176d
2eb48fa
45c61f2
e76045e
3fd5a45
c78c807
c94c29c
9052d40
9b9f146
7cfbd3c
2aabb6a
6149ba4
b8fc383
fcfa7b3
db30b19
a7266c9
49834ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this line is deleted? 🤨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a comment explaining that we have different kinds of sizes which results in four different tables might be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
assert
that the length is actually of that size?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do check most of these above, don't we?
This is just a comment for future us so we remember the length of these features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yes, we do check most of the
length = 1
things...I think I also meant the
length = num_inner_nodes = num_leaves - 1
andlength = num_leaves
parts... We could addlength
as a parameter toparse()
and asserts the length there for the rest?