Add backend refresh() method #1955
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
added
the
Changelog: New Feature
jyu00
reviewed
Sep 30, 2024
jyu00
reviewed
Oct 1, 2024
| instance=self._instance, | ||
| ): | ||
| self._configuration = config | ||
| self._get_properties(datetime=python_datetime.now()) |
There was a problem hiding this comment.
Looking at the code, _get_properties() and properties() seem to nearly identical, with the exception that the latter support refresh. I wonder if we can consolidate them and just pass refresh=True.
There was a problem hiding this comment.
Yeah I think we can consolidate the two methods - i'll do that when fixing #1956
test/integration/test_backend.py
Outdated
Comment on lines
127
to
130
| old_target = backend.target_history(datetime=datetime.now() - timedelta(60)) | ||
| self.assertIsNotNone(old_target) | ||
| backend.refresh() | ||
| self.assertNotEqual(old_target, backend.target) |
There was a problem hiding this comment.
haha I just opened an issue that, when fixed, would make this test less useful.
I think you can just do
old_target = backend.target
backend.refresh()
new_target = backend.target
and assert old_target and new_target are different objects (to validate target is not cached)
…it-ibm-runtime into target-refresh-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments
Fixes #