-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local channel #1793
Add local channel #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one comment from the original issue - #1608 (comment)
In the refresh method we can add a better error message if the local service is passed in
I also just noticed that since this would expose the
|
I believe the way the stacklevels work, the deprecation message will only show up if |
…it-ibm-runtime into add-local-channel
Summary
Details and comments
Fixes #1608