Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local channel #1793

Merged
merged 29 commits into from
Jul 22, 2024
Merged

Add local channel #1793

merged 29 commits into from
Jul 22, 2024

Conversation

ptristan3
Copy link
Collaborator

Summary

Details and comments

Fixes #1608

@ptristan3 ptristan3 added the Changelog: New Feature Include in the Added section of the changelog label Jul 10, 2024
@ptristan3 ptristan3 marked this pull request as ready for review July 10, 2024 19:35
@ptristan3 ptristan3 requested a review from kt474 July 10, 2024 19:35
qiskit_ibm_runtime/fake_provider/fake_backend.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/qiskit_runtime_service.py Outdated Show resolved Hide resolved
release-notes/unreleased/1793.feat.rst Outdated Show resolved Hide resolved
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one comment from the original issue - #1608 (comment)

In the refresh method we can add a better error message if the local service is passed in

@jyu00
Copy link
Collaborator

jyu00 commented Jul 18, 2024

I also just noticed that since this would expose the QiskitRuntimeLocalService with this change, we should make its run() method private, because we don't want people to do service.run().

QiskitRuntimeService.run() issues a deprecation message today. But all of our primitives call that method, so wouldn't everyone get that deprecation message? I'm very puzzled as I'm running 0.25 but not seeing the deprecation message. @kt474 do you know what's going on?

@kt474
Copy link
Member

kt474 commented Jul 18, 2024

QiskitRuntimeService.run() issues a deprecation message today. But all of our primitives call that method, so wouldn't everyone get that deprecation message? I'm very puzzled as I'm running 0.25 but not seeing the deprecation message. @kt474 do you know what's going on?

I believe the way the stacklevels work, the deprecation message will only show up if service.run() is called directly - so the message will not show up when calling service._run() or from within in the primitives. Having said that I should've updated the primitives to also use the private _run method.

@ptristan3 ptristan3 merged commit b3d0f58 into Qiskit:main Jul 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add local channel
3 participants