Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/crud #355

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Refactor/crud #355

wants to merge 10 commits into from

Conversation

Gonzom
Copy link
Contributor

@Gonzom Gonzom commented Mar 20, 2021

Creating a version 2 system of the current user and event schemas and models and connecting them with CRUD operations.
Tests are included.

The version 2 is not integrated in the system and is segregated to allow easier implementation.

Creating a version 2 system of the current user and event schemas and models and connecting them with CRUD operations. Tests are included.

The version 2 is not integrated in the system and is segregated.
Updated relevant code and tests.
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! Great code, well tested. Kudos

app/database/models_v2.py Outdated Show resolved Hide resolved
app/database/schemas_v2.py Outdated Show resolved Hide resolved
app/internal/languages.py Outdated Show resolved Hide resolved
app/internal/languages.py Outdated Show resolved Hide resolved
This constraint makes it so a user can only be added once to an event.
* Added missing test for base attributes.
* Renamed get_set tests to only get_, as they don't preform any setting of values.
* Fixed a bug with test_get_change_owner()
* Added an additional test to test_get_add_delete_members() to check that the unique constraint works.
* Added new util function.
This change better reflects the data it represents as the data is not a date object, but a complete datetime object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants