Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #325: Profile Page #326

Merged
merged 4 commits into from
Feb 20, 2021

Conversation

OdeYec
Copy link
Collaborator

@OdeYec OdeYec commented Feb 20, 2021

Fixed the issues with the profile page and separated the page components into smaller files.

I might have gone overboard with separating the page into sub-files so let me know if you think it's too much. It did, however, make it infinitely easier to debug the issues (there were so many missing s).

Also did some unrelated side-fixes for two issues that weren't fixed well on previous conflict, but they were too small to deserve their own PR.

image

@OdeYec OdeYec linked an issue Feb 20, 2021 that may be closed by this pull request
5 tasks
@yammesicka yammesicka merged commit b8f94b2 into PythonFreeCourse:develop Feb 20, 2021
@OdeYec OdeYec deleted the profile_page_fix branch March 21, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: broken profile page
2 participants