Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/HebrewView #280

Open
wants to merge 71 commits into
base: develop
Choose a base branch
from
Open

Feature/HebrewView #280

wants to merge 71 commits into from

Conversation

elor555
Copy link

@elor555 elor555 commented Feb 14, 2021 •
edited
Loading

Create a new feature- Adding a Hebrew date to each calendar date(on the dayview page)

@elor555 elor555 changed the title add hebrew dates to calendar-nre feature Feature/HebrewView Feb 14, 2021
ivarshav
ivarshav reviewed Feb 15, 2021
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
ivarshav
ivarshav reviewed Feb 15, 2021
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
ivarshav
ivarshav reviewed Feb 15, 2021
View reviewed changes
app/routers/calendar.py Outdated Show resolved Hide resolved
ivarshav
ivarshav reviewed Feb 16, 2021
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
IdanPelled
IdanPelled reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@IdanPelled IdanPelled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work.

For next time, please try and give more spasific commit messages read more.

app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
tests/test_calendar_grid.py Outdated Show resolved Hide resolved
Gonzom
Gonzom reviewed Feb 24, 2021
View reviewed changes
app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
app/internal/json_data_loader.py Outdated Show resolved Hide resolved
app/routers/dayview.py Outdated Show resolved Hide resolved
app/templates/calendar_day_view.html Outdated Show resolved Hide resolved
app/templates/calendar_day_view.html Outdated Show resolved Hide resolved
app/templates/calendar_day_view.html Outdated Show resolved Hide resolved
yammesicka
yammesicka requested changes Feb 24, 2021
View reviewed changes
app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
app/routers/calendar.py Show resolved Hide resolved
app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
@yammesicka
Copy link
Member

Also, please add some tests :)

yammesicka
yammesicka requested changes Feb 24, 2021
View reviewed changes
app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
yammesicka
yammesicka requested changes Feb 24, 2021
View reviewed changes
app/internal/hebrew_date_view.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonzom Gonzom Gonzom left review comments

@IdanPelled IdanPelled IdanPelled left review comments

@yammesicka yammesicka yammesicka requested changes

@ivarshav ivarshav ivarshav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elor555 @codecov-io @yammesicka @ivarshav @Gonzom @IdanPelled