Refactor/delete language column #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/shareable-event
…nto style-daily_view
Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work.
Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work. fixed after taking notes.
Fix the "Task pending" RuntimeError
* feat: astronomy
* feat: add on this day from wiki
* feat: daily horoscope by sign
* Currency feature
* Support adding category to a new or exisiting event
… Fix (PythonFreeCourse#218) * fix: grid responsiveness (fills grid to the bottom now)
* Add telegram client
* feat: add i18n support This feature includes the core functions added to /internal, English and Hebrew json files, removal of text strings from the html files, updates to the routes and model updates. Also included are tests. Please note, that this feature is waiting on user registration for final hooks. * fix(i18n): correct flake8 line length errors * fix(i18n): attempt to fix build crash at get_translations_dicts() and move foreignkey to last column as requested in CR. Additional minor doc fixes. * fix(i18n): simplify check of language file path between live and testing This change hopefully adds this line to the code coverage. * fix(i18n): replace glob with path.glob This change reduces the amount of imports needed and also uses one dir path for both tests and live. * fix(i18n): revert attempted code improvement * fix(i18n): added missing language_id to placeholder user * fix(i18n): added simple test for home * fix(i18n): code review fixes * fix(i18n): split the html result dict into two sub-dicts, "variables" and "localized" and the creation of the Jinja2TemplateResponse is now handled in internal/utilities. * fix(i18n): fixed CR request to not use global state for translations The translations are now handled with @lru_cache and the function is only re-handled when a new language code parameter is used. This should be the last edit (unless any crash) to this version of the translation feature.
* feat: add a workflow for extracting translations from files * fix(translations-workflow): add install dependencies step * fix(translations-workflow): trying a fix * Apply automatic translateable string changes Co-authored-by: Gonzom <[email protected]>
* feat/text_editor added bleach support for cleaning malicious html added summernote text editor support added modal for using summernote texteditor. added testing to cleaning html
* fix: typo correction * Apply automatic translatable string changes * fix: set workflow only for main push
* adding func to create new event
…FreeCourse#201) * feat: improve import file to calendar and extend capabilities
* Celebrity birthdays feature
* fix: reformat code First pass at cleaning up the project code. This fix includes reformatting the code, spacing, and import order. Note that the HTML files had inconsistent indent regarding jinja2 IF and FOR blocks. This push removes the indent from the places it was in, and a future push will restore a consistent indent to all instances. * fix: fix unaligned for hanging indent
|
Mistake. I pushed to main instead of develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#255