Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #111

Merged
merged 10 commits into from
Jul 5, 2023

Conversation

bbelderbos and others added 7 commits October 6, 2021 11:34
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.4.0](pre-commit/pre-commit-hooks@v4.0.1...v4.4.0)
- [github.com/pycqa/flake8: 3.9.2 → 6.0.0](PyCQA/flake8@3.9.2...6.0.0)
- [github.com/pycqa/isort: 5.9.3 → 5.12.0](PyCQA/isort@5.9.3...5.12.0)
- [github.com/psf/black: 21.7b0 → 23.3.0](psf/black@21.7b0...23.3.0)
- [github.com/pre-commit/mirrors-mypy: v0.910 → v1.4.1](pre-commit/mirrors-mypy@v0.910...v1.4.1)
- [github.com/asottile/pyupgrade: v2.23.1 → v3.8.0](asottile/pyupgrade@v2.23.1...v3.8.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 0a7f008 to aaeedef Compare July 3, 2023 21:52
@bbelderbos bbelderbos requested a review from pogross July 4, 2023 13:31
@bbelderbos
Copy link
Collaborator

@pogross
Copy link
Member

pogross commented Jul 4, 2023

Would need to get the latest dev changes to master @bbelderbos :)

@pogross
Copy link
Member

pogross commented Jul 4, 2023

Also quick fixed a linting error and vulnerability of requests. @bbelderbos could you already test it on slack? can you merge dev to master?

@bbelderbos bbelderbos changed the base branch from master to develop July 5, 2023 09:16
@bbelderbos
Copy link
Collaborator

bbelderbos commented Jul 5, 2023

@pogross changed base branch to develop which has latest code to have tests run against that.

I logged into test slack (called "SlackBotTest" or "slackbottest-gruppe") but last time it did not work, gonna read up on how to have the uat code (that has latest develop code with your last changeset), connect properly with that slack.

@bbelderbos
Copy link
Collaborator

Resolved merge conflict

@bbelderbos bbelderbos merged commit ba9d25a into develop Jul 5, 2023
4 checks passed
@bbelderbos
Copy link
Collaborator

@pogross not sure why some tests did not complete, but the changes here should not impact performance.

I was able to run through README and set up a new karmabot in a test slack and develop branch works 🎉

image image

So let me merge all to master and push to prod and validate it works there too ...

Thanks for your patience, this clearly got on the backburner 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants