#359 pytest ii tests cache #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundobatista
requested changes
May 27, 2019
There was a problem hiding this comment.
Great work!! Thanks!
There are some stuff to change/improve, but most of these are questions. Feel free to discuss any detail not clear through Telegram, to reduce the cycles here.
After the easy improvements are done, let's focus on the failing test above.
Thanks again,
|
@facundobatista now it fails because i removed the skipped test. |
facundobatista
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored all the testcases inside of
test_cache.pyto diferents files in the foldertest_cache.I thought it will be nice to have a folder with a specific
conftest.pyand split the file in many files in order to gain order.