Skip to content

Commit

Permalink
Renamed assembly name to original assembly name. (#29)
Browse files Browse the repository at this point in the history
- Going to .NETStandard, the build process was using a different Assembly name. So this is now going back to the original one.
- Make sure the correct configuration is used during CI packing.
- Renamed ReleaseNotes.md to ChangeLog.md.
  • Loading branch information
PureKrome authored Jun 7, 2017
1 parent e27da25 commit 33448c8
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 45 deletions.
25 changes: 25 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Change Log
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).


## [6.1.0] - 2017-06-07
### Fixed
- The new .NET Standard packaging (in AppVeyor) was creating an incorrect Assembly name. :blush:

## [6.0.0] - 2017-05-27
### Changed
- Supports .NET Standard 1.4! Woot!

### Fixed
- #27: Uri fails to compare/equals when Uri contains characters that get encoded.

## [5.1.0] - 2017-02-06
### Added
- Support for `Headers` in `HttpMessageOptions`.


## [1.0.0 -> 5.0.0] - 2014-08-07 -> 2017-02-06
### Added
- Inital and subsequent releases in supporting faking an `HttpClient` request/response.
9 changes: 0 additions & 9 deletions ReleaseNotes.md

This file was deleted.

2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ build_script:

test_script:
- dotnet test %tests_project_file% -c %CONFIGURATION% -v normal --no-build
- dotnet pack %library_project_file% /p:Version=%APPVEYOR_BUILD_VERSION% --no-build
- dotnet pack %library_project_file% -c %CONFIGURATION% /p:Version=%APPVEYOR_BUILD_VERSION% --no-build

artifacts:
- path: '**\*.nupkg'
Expand Down
7 changes: 1 addition & 6 deletions src/HttpClient.Helpers/FakeMessageHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,7 @@ public FakeHttpMessageHandler(IEnumerable<HttpMessageOptions> lotsOfOptions)
/// <param name="exception">The exception that will occur.</param>
public FakeHttpMessageHandler(HttpRequestException exception)
{
if (exception == null)
{
throw new ArgumentNullException(nameof(exception));
}

_exception = exception;
_exception = exception ?? throw new ArgumentNullException(nameof(exception));
}

protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,
Expand Down
2 changes: 2 additions & 0 deletions src/HttpClient.Helpers/HttpClient.Helpers.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
<PackageIconUrl>http://i.imgur.com/bR4Yf.jpg</PackageIconUrl>
<RepositoryUrl>https://github.com/PureKrome/HttpClient.Helpers</RepositoryUrl>
<PackageTags>httpclient worlddomination worldomination unicorn magicalunicorn magical-unicorn</PackageTags>
<RootNamespace>WorldDomination.Net.Http</RootNamespace>
<AssemblyName>WorldDomination.HttpClient.Helpers</AssemblyName>
</PropertyGroup>

<ItemGroup>
Expand Down
26 changes: 0 additions & 26 deletions src/HttpClient.Helpers/HttpClient.Helpers.nuspec

This file was deleted.

7 changes: 4 additions & 3 deletions src/HttpClient.Helpers/HttpMessageOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace WorldDomination.Net.Http
{
public class HttpMessageOptions
{
private const string _anyValue = "*";
private const string AnyValue = "*";
private HttpContent _httpContent;
private string _httpContentSerialized;

Expand All @@ -32,7 +32,7 @@ public class HttpMessageOptions
/// </summary>
public HttpContent HttpContent
{
get { return _httpContent; }
get => _httpContent;
set
{
_httpContent = value;
Expand All @@ -50,11 +50,12 @@ public HttpContent HttpContent
// Note: I'm using reflection to set the value in here because I want this value to be _read-only_.
// Secondly, this occurs during a UNIT TEST, so I consider the expensive reflection costs to be
// acceptable in this situation.
// ReSharper disable once UnusedAutoPropertyAccessor.Local
public int NumberOfTimesCalled { get; private set; }

public override string ToString()
{
var httpMethodText = HttpMethod?.ToString() ?? _anyValue;
var httpMethodText = HttpMethod?.ToString() ?? AnyValue;

var headers = Headers != null &&
Headers.Any()
Expand Down

0 comments on commit 33448c8

Please sign in to comment.