Add Optional skipChecks to Disable Array Size Check
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open the PR for prismarine-nbt? You don't need to wait for a PR to be merged to use it in another PR if there is a chain ; simply set the dependency to point to a branch on github ( |
|
This option should be added to docs |
PR is open. Let me know if I should approach anything differently.
Good idea! I added this to the docs and type definitions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
skipChecksto disable a max array length check. The array length check was added to address V8 crash concerns, however this is not a concern for some use cases.This implements the support necessary to address #150 and #85. The prismarine-nbt PR that uses these changes can be found here.