Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the URL api rather than normalize-url #3614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the URL api rather than normalize-url #3614

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Collaborator

@jcoyne jcoyne commented Jan 24, 2023

The URL API is now in all browsers that we support: https://caniuse.com/url

@jcoyne jcoyne force-pushed the url-api branch 2 times, most recently from 98990e1 to b607f9b Compare January 25, 2023 14:23
@cbeer
Copy link
Collaborator

cbeer commented Jan 25, 2023

I think normalize-url provides additional functionality to deal with slightly malformed IIIF manifest data, doesn't it? I don't think it's completely equivalent to URL.

@jcoyne
Copy link
Collaborator Author

jcoyne commented Jan 25, 2023

@cbeer they are not equivalent, but I think that URI handles the cases we actually care about. We do have some bad tests though that rely on this difference (#3620 for example)

@jcoyne
Use the URL api rather than normalize-url
89c615b 
The URL API is now in all browsers that we support: https://caniuse.com/url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoyne @cbeer