Fix selection direction + selection css (microsoft#228869)

* fix selection direction + selection css * rm todo comment
Progressive-Insurance · Sep 17, 2024 · 2925ed9 · 2925ed9
1 parent 130a8e4
commit 2925ed9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/vs/workbench/contrib/notebook/browser/contrib/multicursor/notebookMulticursor.ts b/src/vs/workbench/contrib/notebook/browser/contrib/multicursor/notebookMulticursor.ts
@@ -289,6 +289,7 @@ export class NotebookMultiCursorController extends Disposable implements INotebo
 				deltaEndCol: e.selection.endColumn - e.oldSelections[0].endColumn,
 				deltaEndLine: e.selection.endLineNumber - e.oldSelections[0].endLineNumber,
 			};
+			const translationDir = e.selection.getDirection();
 
 			this.trackedMatches.forEach(match => {
 				const controller = this.cursorsControllers.get(match.cellViewModel.uri);
@@ -301,7 +302,7 @@ export class NotebookMultiCursorController extends Disposable implements INotebo
 					const newStartLine = selection.startLineNumber + translation.deltaStartLine;
 					const newEndCol = selection.endColumn + translation.deltaEndCol;
 					const newEndLine = selection.endLineNumber + translation.deltaEndLine;
-					return new Selection(newStartLine, newStartCol, newEndLine, newEndCol);
+					return Selection.createWithDirection(newStartLine, newStartCol, newEndLine, newEndCol, translationDir);
 				});
 
 				controller.setSelections(new ViewModelEventsCollector(), e.source, newSelections, CursorChangeReason.Explicit);
@@ -615,6 +616,7 @@ export class NotebookMultiCursorController extends Disposable implements INotebo
 			}
 			controller.setSelections(new ViewModelEventsCollector(), undefined, delSelections, CursorChangeReason.Explicit);
 		});
+		this.updateLazyDecorations();
 	}
 
 	public async deleteRight(): Promise<void> {
@@ -644,6 +646,7 @@ export class NotebookMultiCursorController extends Disposable implements INotebo
 			}
 
 		});
+		this.updateLazyDecorations();
 	}
 
 	async undo() {

diff --git a/src/vs/workbench/contrib/notebook/browser/media/notebook.css b/src/vs/workbench/contrib/notebook/browser/media/notebook.css
@@ -453,8 +453,7 @@
 .nb-multicursor-selection {
 	top: 0;
 	min-width: 1.9px;
-	background-color: var(--vscode-notebook-symbolHighlightBackground);
-	/* TODO@Yoyokrazy: ^^highlight/selection color */
+	background-color: var(--vscode-editor-selectionBackground);
 
 	/* unsure about these two */
 	overflow: hidden;