Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaFX_GUI #257

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

JavaFX_GUI #257

wants to merge 35 commits into from

Conversation

chrisfaltsetas
Copy link

@chrisfaltsetas chrisfaltsetas commented May 19, 2019 •
edited
Loading

This is a work in progress for a JavaFX GUI with the use of SceneBuilder.
Please merge it in a new branch (JavaFX_GUI) so more people can contribute.
#204

@chrisfaltsetas
Cleanup unused imports, memory leaks
c5371f6
@chrisfaltsetas
Change JAdventure to be a JavaFX Application. Implement Main Menu scene
6fb673c
@chrisfaltsetas
Setup custom quit event handler
8fddd7e
@chrisfaltsetas
Initialize controller references for Main Menu
dd19f62
@chrisfaltsetas
Create initial files for the profile menu
24bd8f4
@chrisfaltsetas
Re-organize controllers. Add profile grid
5f5ba1f
@chrisfaltsetas
Complete profile menu design
1adee8e
@chrisfaltsetas
Set on mouse click profile loading
be49df8
@chrisfaltsetas
Set on mouse click profile deletion + alert
aec6a89
@chrisfaltsetas
Add new game, class selector scene + removed unused FXML components f…
46a084b 
…rom controllers
@chrisfaltsetas
Remove unused methods and classes
b930419
@chrisfaltsetas
Load character name - no implementation
b4f6dbb
@chrisfaltsetas
Complete character creation + first save (profile loading works prope…
80ee17b 
…rly)
@chrisfaltsetas
Add working welcome scene
5075055
@chrisfaltsetas
Add welcome funcionality when loading profile
daacd92
@chrisfaltsetas
Add empty Game scene with working save function
4389e6a
@chrisfaltsetas
Create location descriptor and health bar
cff392d
@chrisfaltsetas
Add directional buttons
f59ff4e
@chrisfaltsetas
Add 2 directional methods. Cleanup imports
79ecd40
@chrisfaltsetas
Allign new directional buttons correctly
41abaaa
@chrisfaltsetas
Create minimap tiles
73619a7
@chrisfaltsetas
Color code minimap exits + reload after moving
6403e92
@chrisfaltsetas
Remove save option from alert on close request
be229d1
@chrisfaltsetas
Setup simple terminal chat
115a1bb
@chrisfaltsetas
Enable wrap text
399dcc1
@chrisfaltsetas
Remove terminal-chat
43dfe19
@chrisfaltsetas
Block javafx version warnings and MenuBarSkin caused Exceptions from …
2a5239a 
…printing. Set grids for exits
@chrisfaltsetas
Add visuals for existance of items/monsters/npcs around current location
2a8b660
@chrisfaltsetas
Add backpack view
c48ea7d
@chrisfaltsetas
Resize and cleanup backpack
52ea8e9
@chrisfaltsetas chrisfaltsetas changed the title Java fx gui JavaFX_GUI #204 May 19, 2019
@chrisfaltsetas chrisfaltsetas changed the title JavaFX_GUI #204 JavaFX_GUI May 19, 2019
@paddatrapper
Copy link
Contributor

Done: https://github.com/Progether/JAdventure/tree/JavaFX_GUI

I haven't had a chance to review this yet, so I'll leave the PR open. Thanks for your work!

jdevfullstack
jdevfullstack reviewed Aug 13, 2020
View reviewed changes
Copy link

@jdevfullstack jdevfullstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you don't create a pull request in progress. That's actually a bad practice. Rather, you create small changes with certain focus. Just like what happened, the changes ended up with merge conflicts that we don't want to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevfullstack jdevfullstack jdevfullstack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisfaltsetas @paddatrapper @jdevfullstack