Minecraft 1.20.2 support

[rom1504]

migrated from #3243

[rom1504]

that looks pretty suspicious, not sure if it's right

[wgaylord]

I suspect it is correct based on existing code using the opposite condition. https://github.com/PrismarineJS/mineflayer/blob/master/lib/plugins/entities.js#L42

Not sure if what its being used for is correct tho.

[extremeheat]

named_entity_spawn was removed, so players spawn with the generic spawn_entity packet. However there are alot of unhandled fields that are not currently accounted for -

mineflayer/lib/plugins/entities.js

Line 132 in a0a5777

bot._client.on('named_entity_spawn', (packet) => {

[wgaylord]

I think the only thing left is to fix what ever is breaking the External Bed and Elytra tests. Then fix the Internal tests since they are all totally failing.

[wgaylord]

Found PrismarineJS/minecraft-data#817 to be why both the External Bed and Elytra tests are failing

[extremeheat]

Also, node v20 is failing now if anyone has time to look into it:

> mocha --reporter spec --exit

/workspaces/mineflayer/test/externalTests/gamemode.js:6
  bot.test.becomeCreative()
           ^

TypeError: Cannot read properties of undefined (reading 'becomeCreative')

Likely related to timing/scheduling

Also, once entity tests are fixed someone should test some examples in-game to see important untested things are working ok (like pathfinder)

[wgaylord]

okay, so the major thing stopping this is changes to the entity spawning packet in both Mineflayer and in the internal tests
https://github.com/PrismarineJS/mineflayer/blob/mc-1.20.2/lib/plugins/entities.js#L132-L157 is how we used to handle player spawns. For 1.20.2+ players spawn using the same as other mobs, partially implemented here https://github.com/PrismarineJS/mineflayer/blob/mc-1.20.2/lib/plugins/entities.js#L196-L224 We need to fill out the rest of the fields for the player.

This same sort of change needs to happen on in the integral tests based on version. Where https://github.com/PrismarineJS/mineflayer/blob/mc-1.20.2/test/internalTest.js#L635-L647 and https://github.com/PrismarineJS/mineflayer/blob/mc-1.20.2/test/internalTest.js#L700-L712 need to be setup so if we are not 1.20.2+ they are used and if we are 1.20.2+ something like https://github.com/PrismarineJS/mineflayer/blob/mc-1.20.2/test/internalTest.js#L786-L800 is used (of course with the correct values.)

[rom1504]

@wgaylord anything unclear about it or you just need to do it?

[wgaylord]

Mostly just need to do it, wanted to document exactly what was still needed, incase I don't get the time to work on it.

[extremeheat]

Ok, should be passing now. Required changes were:

• server.on login (packet) -> playerJoin (nmp event) to handle play state
• named_entity_spawn is now done with spawn_entity packet
• dimension codec is sent outside login packet now (before play state)

[rom1504]

would be good to make that a feature

[extremeheat]

done, looks like removing dupe PrismarineJS/minecraft-data@587a134 caused range to be incorrect breaking chunk lighting, just fixed that

[rom1504]

great

[rom1504]

Remaining here, test some examples manually

• Inventory.js
• digger
• chest
• check previous PRs

[rom1504]

I tested digger, chest, inventory, jumper, viewer and pathfinder, all working

[rom1504]

/makerelease