Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.2 and 1.20.3 missing metadataKeys in entities.json. #817

Open
wgaylord opened this issue Jan 2, 2024 · 8 comments
Open

1.20.2 and 1.20.3 missing metadataKeys in entities.json. #817

wgaylord opened this issue Jan 2, 2024 · 8 comments

Comments

@wgaylord
Copy link
Contributor

wgaylord commented Jan 2, 2024

Seems that the minecraft-data-generator-server doesn't output that information, and the tests don't check that it exists.

I will look into getting this information into the entities.json on both versions and look into if minecraft-data-generator-server can generate it.

@wgaylord
Copy link
Contributor Author

wgaylord commented Jan 2, 2024

Also just looked and Burger also does not extract this info, so it might be manual.

@rom1504
Copy link
Member

rom1504 commented Jan 2, 2024

You can look at git blame info to find the commit that added it previously

@rom1504
Copy link
Member

rom1504 commented Jan 2, 2024

#723

@rom1504
Copy link
Member

rom1504 commented Jan 2, 2024

#710 info on how to extract
Would be good to automate that

@extremeheat
Copy link
Member

Yeah, looks like it was not added to the doc. Running the extraction script in tools/js will generate it. The reason there is no test is that it's technically optional, as we don't have the data for all the versions. I guess a test could be done to check if versions newer than X have the field, but maybe the better solution would be to try and get all the data back.

@wgaylord
Copy link
Contributor Author

wgaylord commented Jan 2, 2024

Personally I dont see as technically optional when mineflayer requires it to pass all its tests on current versions. I am looking into adding support in minecraft-data-generator-server.

@extremeheat
Copy link
Member

mineflayer is independent to minecraft-data, so what's optional in minecraft-data may indeed not be optional for mineflayer

@rom1504
Copy link
Member

rom1504 commented Jan 2, 2024

Adding more data validation and in general data quality tests to Minecraft data would definitely help.
It can be done as a failing test but it can also be implemented as a report that is sent by a bot.

See PrismarineJS/prismarine-packet-dumper#82 (comment) as an example of what a quality report might look like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants