Add 1.16.5 support and future-proof version system #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandapip1
changed the title
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
rom1504
reviewed
Jan 4, 2024
|
left some more comments but most things look good besides that |
|
would be good if we can finally make progress on version supports for flying squid |
|
We've got a green! |
|
Left one comment about that onItemPlace |
extremeheat
reviewed
Jan 5, 2024
|
Thanks for the PR. There's a pretty big pile of new versions to get this to current: 1.17, 1.18, 1.19, 1.20 |
|
/makerelease |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: PrismarineJS/minecraft-data#823; new version of node-minecraft-dataDone!Forked from #599. The author appears to have gone AWOL.
The goal of this PR is to add version support up to 1.18.2Never mind. That will take a lot more time. For now, this has stable 1.16.5 support.
Fixes #447 and the following unreported minor issues:
Closes #599