Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.5 support #518

Closed
wants to merge 6 commits into from
Closed

Conversation

GroobleDierne
Copy link
Contributor

Close #447
Still work in progress.

I have some questions: here https://github.com/PrismarineJS/flying-squid/blob/master/src/lib/version.js#L2
the supported versions are specified with their minor version but here https://github.com/PrismarineJS/flying-squid/blob/master/src/index.js#L46 the minor version is ignored. So I was wondering if I should change it to check also the minor version, so only the latest minor version will be supported for each Minecraft major version. That would simplify development (especially for 1.16 where there are a lot of differences between 1.16.1 and 1.16.2 and superior) but it will reduce the number of available versions.

Also, I didn't found a way to trigger a multi_block_change packet (here https://github.com/PrismarineJS/flying-squid/blob/master/src/lib/plugins/blockUpdates.js#L153)

@u9g
Copy link
Member

u9g commented Jul 23, 2021

Also, I didn't found a way to trigger a multi_block_change packet (here https://github.com/PrismarineJS/flying-squid/blob/master/src/lib/plugins/blockUpdates.js#L153)

What do you mean by you didn’t?

@GroobleDierne
Copy link
Contributor Author

Also, I didn't found a way to trigger a multi_block_change packet (here https://github.com/PrismarineJS/flying-squid/blob/master/src/lib/plugins/blockUpdates.js#L153)

What do you mean by you didn’t?

Flying-squid seems to send this packet if there is more than one block update at a tick (for example, an explosion), I didn't found a way to satisfies this condition just by breaking blocks in-game and, I was wondering if there is a /explosion command or a /fill command or any other way to make more than one update per tick in-game.

@u9g
Copy link
Member

u9g commented Sep 24, 2021

How far along is this?

@Saiv46
Copy link
Contributor

Saiv46 commented Dec 11, 2021

@GroobleDierne Hi, can I remake this PR if you don't want to finish this?

@GroobleDierne
Copy link
Contributor Author

Feel free to do so, I won't have the time to finish it before long.

@rom1504 rom1504 mentioned this pull request Dec 25, 2021
@rom1504
Copy link
Member

rom1504 commented Mar 8, 2022

anyone feel like finishing this?
@darksunlight maybe ?

@BasToTheMax
Copy link

  • How far are you?
  • What needs to be done to support 1.16.5?

@GroobleDierne
Copy link
Contributor Author

I don't have time to finish it but if someone does I can pull their changes into this branch

@BasToTheMax
Copy link

I don't have time to finish it but if someone does I can pull their changes into this branch

I understand that, but I need to know what changes need to be made until 1.16.5 works

@GroobleDierne
Copy link
Contributor Author

I don't have time to finish it but if someone does I can pull their changes into this branch

I understand that, but I need to know what changes need to be made until 1.16.5 works

The multi_blocks_change packet still needs to be tested, in theory I updated it but at the time that packet was never used by flying-squid so I wasn't able to test it.
Also there is still a pending question that I asked in the PR description, it's that I took the initiative of only supporting the latest minor release of each major minecraft release (so not supporting 1.16.0-1.16.4 but only 1.16.5) because I saw that albeit the list of supported versions contained every minor release for every major release, when checking if the server supports a specific version, the minor number is stripped and only the major is looked for (1.16 instead of 16.5), so we need to know if my initiative is good or not and revert it if so.

@ghost
Copy link

ghost commented Jun 11, 2022

#599

@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

too old, feel free to redo

@rom1504 rom1504 closed this Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.16.2 and 1.16.3 support
5 participants