End of summer Nix cleaning #380
Conversation
getchoo
force-pushed
the
rust-1.80
branch
2 times, most recently
from
02f5ee8
to
50dde10
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
The main package has been added to |
|
I don't quite understand the usefulness of building on all three platforms supported by GH Actions, though. Seems quite wasteful for next to no gain. |
|
I'm not a big fan of it either, but i've caught myself accidentally adding os-specific stuff from time to time (looking at you tokio). I don't know how else we can continuously make sure contributors are able to build locally otherwise The only real option I see is dropping the regular rust linux build and just using Nix instead? |
getchoo
changed the title
this should speed up evaluation a bit by caching all the things
this avoid unnecessary rebuilds
this is how you're supposed to use code scanners apparently
nixpkgs works well enough and gives us a good buffer in dealing with compiler regressions
building for macos and windows with regular old rustc should be enough assurance non-nix users can build the bot
I nitpicked my own Nix
Call it nixpicking
We've also had Docker images failing to build a while because of rust-overlay being bumped to 1.80.0 and one of our deps not working for it yet it seems :/FIXED!We should change the required checks to the Clippy scan, "CI Release Gate", and "Docker Release" in the repo as to avoid things breaking again