UI tests - Add PS versions from 1.7.0.0 ~ 1.7.0.6 to 1.7.8.11 (minor) on php 7.1 #729
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nesrineabdmouleh
commented
Jun 21, 2024
•
nesrineabdmouleh
commented
| Questions | Answers |
|---|---|
| Description? | Add PS versions from 1.7.0.0 ~ 1.7.0.6 to 1.7.8.11 (minor) on php 7.1 |
| Type? | new feature |
| Sponsor company | |
| How to test? | CI is 🍏 |
nesrineabdmouleh
force-pushed
the
addPSVersionsToMatrice
branch
from
c4152c2
to
5340433
Compare
nesrineabdmouleh
changed the title
nesrineabdmouleh
force-pushed
the
addPSVersionsToMatrice
branch
2 times, most recently
from
bba5009
to
853fd3a
Compare
|
The error is happening because an URL we depend on to get data is now invalid. It has been fixed on 1.7.1.0 with PrestaShop/PrestaShop#7597. We cannot fix this issue without modifying the core files on the fly to change the URL before starting the installation. What do you think @nesrineabdmouleh & @gericfo? |
nesrineabdmouleh
force-pushed
the
addPSVersionsToMatrice
branch
from
853fd3a
to
dd9c936
Compare
Progi1984
previously approved these changes
Aug 5, 2024
Yes it wip but to run the jobs the PR should not be in draft |
nesrineabdmouleh
force-pushed
the
addPSVersionsToMatrice
branch
from
5c98d0c
to
b8886b8
Compare
author nesrineabdmouleh <[email protected]> 1718971783 +0200 committer nesrineabdmouleh <[email protected]> 1719836964 +0200 Comment chmod Test-4 Test-5 Test-5 Test-6 Test-7 Test-8 Test-8 Test-9 Fix PR morgan Fix Fix Fix Fix Fix Fix Fix Fix Fix Fix Fix Fix Fix Test Test Add setup PHP Add some fixes Add versions
nesrineabdmouleh
force-pushed
the
addPSVersionsToMatrice
branch
from
1ae20d4
to
8c14345
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.