-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(variable): change 'value' type to Dynamic #277
Draft
mitchnielsen
wants to merge
9
commits into
main
Choose a base branch
from
variable-json-encoding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 4, 2024
-
fix(variable): change 'value' type to JSON
Changes the Variable 'value' type from string to JSON. In PrefectHQ/prefect#13543 and associated changes around May 2024, Variables were updated from simple strings to JSON objects. The Terraform provider has still been treating them as strings, so when folks tried to put JSON-compatible values in them, Terraform would fail to work with them as found in #254 Related to https://linear.app/prefect/issue/PLA-247/changing-variable-to-a-json-value-in-the-ui-makes-next-terraform-run Related to #254
Configuration menu - View commit details
-
Copy full SHA for 07ce76d - Browse repository at this point
Copy the full SHA 07ce76dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77701c1 - Browse repository at this point
Copy the full SHA 77701c1View commit details
Commits on Oct 18, 2024
-
Change variable attribute type to dynamic
The JSON custom type won't work for variables, because they can actually be almost any type - including standalone numbers and strings.
Configuration menu - View commit details
-
Copy full SHA for 5aaa5c6 - Browse repository at this point
Copy the full SHA 5aaa5c6View commit details -
Update test to change value types
Goes from a string to a bool in the test to confirm variables can store multiple types.
Configuration menu - View commit details
-
Copy full SHA for 3d1a587 - Browse repository at this point
Copy the full SHA 3d1a587View commit details -
Correctly test the name change
Before, when trying to test a variable resource name change, we were actually creating an entirely new resource because we use the same (randomized) value for the resource name and the attribute 'name'. To ensure we're updating the same resource, this hard-codes the resource name to 'test'. This shouldn't cause any conflicts with other tests because the resource is created in an ephemeral workspace.
Configuration menu - View commit details
-
Copy full SHA for 535195c - Browse repository at this point
Copy the full SHA 535195cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d48ee - Browse repository at this point
Copy the full SHA 34d48eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7069253 - Browse repository at this point
Copy the full SHA 7069253View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c604f7 - Browse repository at this point
Copy the full SHA 6c604f7View commit details
Commits on Oct 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce850a2 - Browse repository at this point
Copy the full SHA ce850a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.