Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage generation and upload for Python tests #15690

Merged
merged 41 commits into from
Oct 17, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 14, 2024

This PR updates the Unit Tests workflow to gather and upload coverage data for prefect. The coverage data is available at a high level on the summary page of a Unit Tests run (example). A details HTML version is also uploaded as an artifact and available for download if a more detailed view of the coverage is needed. These additions should help reviewers ensure that tests cover new functionality well to prevent future regressions.

This PR also includes a refactor of some tests that were flaking on me.

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Oct 14, 2024
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #15690 will not alter performance

Comparing generate-code-coverage (619ae25) with main (55380bc)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle changed the base branch from main to split-worker-and-runner-tests October 16, 2024 14:34
Base automatically changed from split-worker-and-runner-tests to main October 16, 2024 15:02
@desertaxle desertaxle marked this pull request as ready for review October 17, 2024 19:25
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

are the test_task_runners changes just related to flakes?

@desertaxle
Copy link
Member Author

are the test_task_runners changes just related to flakes?

Yep, they were flaking in this PR, but no longer.

@desertaxle desertaxle merged commit 1511996 into main Oct 17, 2024
39 checks passed
@desertaxle desertaxle deleted the generate-code-coverage branch October 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants