-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage generation and upload for Python tests #15690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
added
the
development
Tech debt, refactors, CI, tests, and other related work.
label
Oct 14, 2024
CodSpeed Performance ReportMerging #15690 will not alter performanceComparing Summary
|
desertaxle
changed the base branch from
main
to
split-worker-and-runner-tests
October 16, 2024 14:34
zzstoatzz
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me!
are the test_task_runners
changes just related to flakes?
Yep, they were flaking in this PR, but no longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Unit Tests workflow to gather and upload coverage data for
prefect
. The coverage data is available at a high level on the summary page of a Unit Tests run (example). A details HTML version is also uploaded as an artifact and available for download if a more detailed view of the coverage is needed. These additions should help reviewers ensure that tests cover new functionality well to prevent future regressions.This PR also includes a refactor of some tests that were flaking on me.