Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow code storage docs improvements #15519

Merged
merged 26 commits into from
Oct 7, 2024
Merged

Flow code storage docs improvements #15519

merged 26 commits into from
Oct 7, 2024

Conversation

discdiver
Copy link
Contributor

@discdiver discdiver commented Sep 27, 2024

Creates Python deploy and prefect.yaml examples and reorganizes the page for more clear and comprehensive examples of flow code storage.

Advances work on #14387

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should define a variable for source for use in from_source so its easier to read and fix the examples of incorrect indenting

docs/3.0/deploy/infrastructure-concepts/customize.mdx Outdated Show resolved Hide resolved
@zzstoatzz zzstoatzz marked this pull request as draft October 2, 2024 16:36
@discdiver discdiver marked this pull request as ready for review October 4, 2024 16:04
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

i have 2 requests:

  • there's some incorrect indenting that I've highlighted
  • can we use descriptive names for the source? like git_repo for example, so it reads more intuitively

docs/integrations/prefect-bitbucket/index.mdx Show resolved Hide resolved
docs/integrations/prefect-github/index.mdx Show resolved Hide resolved
docs/integrations/prefect-github/index.mdx Show resolved Hide resolved
@discdiver
Copy link
Contributor Author

Thanks for the review. Pushed those changes.

@discdiver discdiver merged commit 8d4f975 into main Oct 7, 2024
5 checks passed
@discdiver discdiver deleted the flow-coding branch October 7, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants