-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow code storage docs improvements #15519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should define a variable for source
for use in from_source
so its easier to read and fix the examples of incorrect indenting
Co-authored-by: nate nowack <[email protected]>
Co-authored-by: nate nowack <[email protected]>
Co-authored-by: nate nowack <[email protected]>
Co-authored-by: nate nowack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
i have 2 requests:
- there's some incorrect indenting that I've highlighted
- can we use descriptive names for the
source
? likegit_repo
for example, so it reads more intuitively
Thanks for the review. Pushed those changes. |
Creates Python
deploy
andprefect.yaml
examples and reorganizes the page for more clear and comprehensive examples of flow code storage.Advances work on #14387
Checklist
<link to issue>
"mint.json
.