Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to pyproject.toml #15250

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

switch to pyproject.toml #15250

wants to merge 8 commits into from

Conversation

zzstoatzz
Copy link
Collaborator

i started on this branch trying to improve import strategies but after profiling with cProfile i saw that a lot of time was being spent doing versioneer stuff and read that using setuptools_scm can improve this.

based on

» pytest --benchmark-only --benchmark-min-rounds=10 benches/bench_import.py
Test Main (ms) Branch (ms)
bench_import_prefect 66.04 0.66
bench_import_prefect_flow 314.68 242.98

I think there are many good reasons to switch to setuptools_scm over versioneer

  • we already use it in collections
  • versioneer is unmaintained
  • edit all config in one place (instead of setup.py, setup.cfg and requirements*)

@github-actions github-actions bot added the upstream dependency An upstream issue caused by a bug in one of our dependencies label Sep 5, 2024
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #15250 will not alter performance

Comparing untangling-imports (a4a54ae) with main (2b994af)

Summary

✅ 3 untouched benchmarks

Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it.

@github-actions github-actions bot closed this Oct 4, 2024
@zzstoatzz zzstoatzz reopened this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant