-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to pyproject.toml
#15250
Draft
zzstoatzz
wants to merge
8
commits into
main
Choose a base branch
from
untangling-imports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
switch to pyproject.toml
#15250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
upstream dependency
An upstream issue caused by a bug in one of our dependencies
label
Sep 5, 2024
zzstoatzz
force-pushed
the
untangling-imports
branch
from
September 5, 2024 22:13
02dfb8f
to
1fbe7b7
Compare
CodSpeed Performance ReportMerging #15250 will not alter performanceComparing Summary
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i started on this branch trying to improve import strategies but after profiling with
cProfile
i saw that a lot of time was being spent doingversioneer
stuff and read that usingsetuptools_scm
can improve this.based on
I think there are many good reasons to switch to setuptools_scm over versioneer