-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates to Kubernetes_asyncio for asynchronous support #13910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple comments so far.
at a high level, why are all the .return_value
's added to all the mocks? it seems odd that we have to add it everywhere
src/integrations/prefect-kubernetes/prefect_kubernetes/events.py
Outdated
Show resolved
Hide resolved
src/integrations/prefect-kubernetes/prefect_kubernetes/events.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
cc @desertaxle
src/integrations/prefect-kubernetes/prefect_kubernetes/credentials.py
Outdated
Show resolved
Hide resolved
src/integrations/prefect-kubernetes/prefect_kubernetes/events.py
Outdated
Show resolved
Hide resolved
src/integrations/prefect-kubernetes/prefect_kubernetes/events.py
Outdated
Show resolved
Hide resolved
src/integrations/prefect-kubernetes/prefect_kubernetes/events.py
Outdated
Show resolved
Hide resolved
src/integrations/prefect-kubernetes/prefect_kubernetes/worker.py
Outdated
Show resolved
Hide resolved
src/integrations/prefect-kubernetes/prefect_kubernetes/worker.py
Outdated
Show resolved
Hide resolved
…fect into kubernetes-asyncio
Description
Migrates to use kubernetes_asynio library in order to have better handling of pod evictions and timing out jobs.
Example
No user facing changes happening. Main bulk of the changes are in
_watch_jobs
. It now usestimeout_async
to timeout both, streaming of logs and monitor job events instead of calculating and keeping track of the timeout seconds.Closes: #8409 #12988 #12995 #12071 #6394
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
mint.json
for files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.json
navigation.