Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates to Kubernetes_asyncio for asynchronous support #13910

Merged
merged 126 commits into from
Jul 11, 2024

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Jun 10, 2024

Description

Migrates to use kubernetes_asynio library in order to have better handling of pod evictions and timing out jobs.

Example

No user facing changes happening. Main bulk of the changes are in _watch_jobs. It now uses timeout_async to timeout both, streaming of logs and monitor job events instead of calculating and keeping track of the timeout seconds.

Closes: #8409 #12988 #12995 #12071 #6394

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in docs/mint.json navigation.

Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple comments so far.

at a high level, why are all the .return_value's added to all the mocks? it seems odd that we have to add it everywhere

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

cc @desertaxle

@desertaxle desertaxle added the integrations Related to integrations with other services label Jul 9, 2024
@jeanluciano jeanluciano merged commit 0effc16 into main Jul 11, 2024
13 checks passed
@jeanluciano jeanluciano deleted the kubernetes-asyncio branch July 11, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature fix A fix for a bug in an existing feature integrations Related to integrations with other services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes flow runs remain running on when k8s pods restart
5 participants