-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: add deprecation warning for artifacts created outside of runs #13688
Chore: add deprecation warning for artifacts created outside of runs #13688
Conversation
…ct-outside-flowrun-deprecation-warning
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
Although there seem to be 14 failing tests for this error:
|
chatted sync already but lgtm besides the filter (i think we should update the tests instead) |
CodSpeed Performance ReportMerging #13688 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could add a test for the deprecation warning case? and just out of curiosity, why FutureWarning instead of DeprecationWarning?
@zzstoatzz I will add a test for the warning 👍🏻 I used |
on |
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
mint.json
for files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.json
navigation.