a couple typing and error improvements (#15081)

src/prefect/client/orchestration.py

@@ -1788,6 +1788,12 @@ async def read_deployment(
         Returns:
             a [Deployment model][prefect.client.schemas.objects.Deployment] representation of the deployment
         """
+        if not isinstance(deployment_id, UUID):
+            try:
+                deployment_id = UUID(deployment_id)
+            except ValueError:
+                raise ValueError(f"Invalid deployment ID: {deployment_id}")
+
         try:
             response = await self._client.get(f"/deployments/{deployment_id}")
         except httpx.HTTPStatusError as e:

src/prefect/flows.py

@@ -642,7 +642,7 @@ async def to_deployment(
         cron: Optional[Union[Iterable[str], str]] = None,
         rrule: Optional[Union[Iterable[str], str]] = None,
         paused: Optional[bool] = None,
-        schedules: Optional[List["FlexibleScheduleList"]] = None,
+        schedules: Optional["FlexibleScheduleList"] = None,
         concurrency_limit: Optional[int] = None,
         parameters: Optional[dict] = None,
         triggers: Optional[List[Union[DeploymentTriggerTypes, TriggerTypes]]] = None,
@@ -730,7 +730,7 @@ def my_other_flow(name):
                 work_pool_name=work_pool_name,
                 work_queue_name=work_queue_name,
                 job_variables=job_variables,
-            )
+            )  # type: ignore # TODO: remove sync_compatible
         else:
             return RunnerDeployment.from_flow(
                 self,

tests/client/test_prefect_client.py

@@ -661,6 +661,13 @@ def foo():
     assert lookup.parameter_openapi_schema == {}
 
 
+async def test_read_deployment_errors_on_invalid_uuid(prefect_client):
+    with pytest.raises(
+        ValueError, match="Invalid deployment ID: not-a-real-deployment"
+    ):
+        await prefect_client.read_deployment("not-a-real-deployment")
+
+
 async def test_update_deployment(prefect_client, storage_document_id):
     @flow
     def foo():