fix(AsuraScans): remake the presence to match asura website #8762
+176
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theusaf
requested changes
Sep 27, 2024
websites/A/Asura Scans/presence.ts
Outdated
Comment on lines
24
to
28
| displayPercentage = await presence.getSetting<boolean>("readingPercentage"), | ||
| privacyMode = await presence.getSetting<boolean>("privacy"), | ||
| displayChapter = await presence.getSetting<boolean>("chapterNumber"), | ||
| displayCover = await presence.getSetting<boolean>("showCover"), | ||
| displayButtons = await presence.getSetting<boolean>("showButtons"); |
There was a problem hiding this comment.
For better efficiency, combine this using Promise.all and destructuring.
There was a problem hiding this comment.
Will just the Promise.all do the destructing ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected